Collect fields for modules and metricsets #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ruflin
commented
Apr 26, 2016
ruflin
commented
- Add python script to collect fields.yml files
- Update templates and docs
- Add fields.yml for each module
ruflin
force-pushed
the
fields-collector
branch
2 times, most recently
from
8ba5afa
to
4ff96f6
Compare
| @@ -0,0 +1,36 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
There was a problem hiding this comment.
ups, that was a second try :-( forgot to remove it :-(
ruflin
force-pushed
the
fields-collector
branch
from
4ff96f6
to
0010905
Compare
| print fields_yml | ||
|
|
||
|
|
||
| collect() |
There was a problem hiding this comment.
I'm not much a python programmer, but isn't the convention to use https://docs.python.org/2/library/__main__.html for the entrypoint.
There was a problem hiding this comment.
It's good practice to do that because then you can import functions/classes from other files. Can still be added when actually needed.
* Add python script to collect fields.yml files * Update templates and docs * Add fields.yml for each module
ruflin
force-pushed
the
fields-collector
branch
from
0010905
to
7bdf627
Compare
|
@andrewkroh Thanks for the review. Version with changes pushed. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.